Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface concept schema changes via sdk query updates #126

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Oct 3, 2024

Description

  • Integrates the latest vespa schema changes to accommodate concepts.
  • Integrates new test data that includes concepts.
  • Updates the sdk filtering functionality to enable concept filtering.
  • Updates the unit tests to include tests of the new concept fields.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link

linear bot commented Oct 3, 2024

@THOR300 THOR300 changed the base branch from feature/update-queries-to-contain-concepts-query to main October 7, 2024 10:15
@THOR300 THOR300 changed the title Adding a failing test and the ConceptFilter object. Surface concept schema changes via sdk query updates Oct 7, 2024
src/cpr_sdk/models/search.py Outdated Show resolved Hide resolved
src/cpr_sdk/version.py Outdated Show resolved Hide resolved
@THOR300 THOR300 marked this pull request as ready for review October 7, 2024 13:44
@THOR300 THOR300 requested a review from a team as a code owner October 7, 2024 13:44
@THOR300 THOR300 merged commit 1431551 into main Oct 7, 2024
6 checks passed
@THOR300 THOR300 deleted the feature/pla-204-surface-the-concepts-schema-changes-to-the-queries-in-the branch October 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants